ImalkaPerera opened a new pull request, #6645: URL: https://github.com/apache/fineract/pull/6645
## Description https://issues.apache.org/jira/browse/FINERACT-2945 Resolves the `[unchecked]` javac warnings in two `fineract-loan` test classes. This is a test-only change with no production code or behaviour change, and it uses no `@SuppressWarnings`. It is part of the ongoing compiler-warning reduction effort (FINERACT-959, FINERACT-1790). **`LoanChargeServiceTaxTest`** (1 warning) - `thenReturn(map1, map2)` created a generic array of `Map<TaxComponent, BigDecimal>` for the varargs parameter (`unchecked generic array creation for varargs parameter`). - Replaced with chained stubbing, `.thenReturn(map1).thenReturn(map2)`. Mockito defines this as equivalent: the first call returns `map1`, and the second and later calls return `map2`. **`LoanTransactionDataTest`** (10 warnings) - `mock(List.class)` / `mock(Collection.class)` return a raw type that was assigned to a parameterized variable (`unchecked conversion`). - Replaced with Mockito's type-inferred `mock()`, which infers the mocked type from the assignment target. - Runtime mock types are unchanged. Three variables that were declared `Collection<…>` but initialised with `mock(List.class)` are now declared `List<…>`, so they remain `List` mocks. ## Verification - `./gradlew :fineract-loan:compileTestJava --rerun-tasks`: BUILD SUCCESSFUL, 0 warnings in the two files. - `./gradlew :fineract-loan:test --tests "*LoanChargeServiceTaxTest" --tests "*LoanTransactionDataTest"`: 16 tests, 0 failures. - `spotlessJavaApply`: no formatting changes beyond the edits. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
