Aarti-panchal01 opened a new pull request, #6660: URL: https://github.com/apache/fineract/pull/6660
## Description [FINERACT-1821](https://issues.apache.org/jira/browse/FINERACT-1821): cashiers on PostgreSQL. This continues @IOhacker's #2768, including the integration test galovics asked for there. **PostgreSQL.** `CashierTransactionDataValidator` compared cashier times with MySQL's `TIME()` in native SQL, which PostgreSQL cannot parse: - creating a part-day cashier fails with `syntax error at or near "c"` - every cash disbursal by a user linked to a staff member fails as well, because `validateOnLoanDisbursal` always puts `TIME()` in its query The queries now only filter by staff and date, and the times are compared in Java. **Overlaps.** As discussed with Victor, the old check only refused a new shift when an existing shift's start or end fell inside it. So 10:00-12:00 was accepted for someone already on 08:00-18:00, and a part-day shift was accepted during a full-day assignment. Two assignments of the same staff member now conflict when their dates overlap and either one is full day or their hours overlap. The check also runs on update, excluding the assignment being updated. **Also:** - `Cashier.getHourFromStartTime` read the minutes instead of the hour, so some start time changes were not detected on update. - The cashier request in `TellerApiResourceSwagger` now documents `hourStartTime`, `minStartTime`, `hourEndTime` and `minEndTime`, so the generated clients can create part-day cashiers. **Tests:** - `CashierTransactionDataValidatorTest` and `CashierTest` (unit) - `PartDayCashierTest` (integration, Feign): a part-day cashier is created, overlapping shifts are refused on create and update, and a separate shift is accepted. All 4 pass against a local PostgreSQL 18 build. On the old code, the same create request fails with the syntax error. Verified live on PostgreSQL before and after: part-day cashier creation, the overlap rules, and a cash disbursal by a staff-linked user. The disbursal goes through, and one larger than the cashier's balance is refused with "Cashier do not have sufficient amount". ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
