Abhishek6122008 commented on PR #6595: URL: https://github.com/apache/fineract/pull/6595#issuecomment-6193656618
Thanks for the review, @adamsaghy. You're right, it only checked that some changelog lists each part. Pushed an update: - It now follows the includes from `db.changelog-master.xml`, so the investor case fails with: `.../investor/module-changelog-master.xml: not reachable from .../db.changelog-master.xml, so its 24 part(s) never run`. The `<includeAll>` line is ignored. - Single-quoted `<include>` attributes are recognised, and the leftover comment is fixed. - Added a PR description, unticked the tests box (no test files added), and fixed the dev@ link in the ticket. Develop still passes: 435 parts, all reachable. Could you run the CLI workflow and give it a quick review to confirm everything passes? Thanks! Also, thanks @shubhamchaudhary29 for testing it locally against develop. Since the script has changed since your approval, another look once the CLI workflow passes would be greatly appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
