1cbyc opened a new pull request, #768: URL: https://github.com/apache/fineract-backoffice-ui/pull/768
## What and why Render the repayment start date option labels from the `value` field returned by the live loan-product template, while retaining `description` as a compatibility fallback. The focused regression fixture now matches the real response shape and verifies both options are visible. Closes #759 ## Verification - `npm test -- --watch=false --include='src/app/features/products/loan-product-form.component.test.ts'` (35 passed) - `npm test -- --watch=false` (2,113 passed across 299 files) - `npm run lint` - `npm run format:check` - `npm run i18n:check` - `npm run check:icons` - `npm run check:a11y-names` - `npm run check:template-text` - `npm run check:ui-primitives` - `npm run api:surface` - `bash scripts/check-license.sh` - `npm run build` The regression test failed against the previous template binding with two empty labels and passes with this change. The production build retains the existing header component style-budget warning. ## Screenshots The issue contains the current broken UI screenshot; this change is covered by the DOM regression test. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] No new component or service code was added. - [x] No new user-facing strings were added. - [x] I added focused regression coverage. - [x] This bug fix does not change a workflow or require a new real-backend e2e journey. - [x] The commit is signed. - [x] This is a bug fix, so developer-list feature discussion does not apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
