priyam99 commented on code in PR #172: URL: https://github.com/apache/fineract-loan-origination/pull/172#discussion_r4299507844
########## src/main/java/org/apache/fineract/los/exception/GlobalExceptionHandler.java: ########## Review Comment: Good point. I added Cucumber scenarios that call staff/admin endpoints with a real customer JWT through the full filter chain. They return 403 with `MSG_ACCESS_DENIED` (which only this handler sends), and 500 without the handler, so the denial does reach it. ########## src/test/java/org/apache/fineract/los/api/MethodSecurityAuthorizationTest.java: ########## Review Comment: Added two more: a customer reading approval history (staff-only) and a loan officer registering a customer account (admin-only). Both get 403, and the protected services are never called. ########## src/main/java/org/apache/fineract/los/exception/LosErrorConstants.java: ########## Review Comment: Thanks! ########## src/test/java/org/apache/fineract/los/exception/GlobalExceptionHandlerTest.java: ########## Review Comment: Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
