AnvayKharb commented on code in PR #6187:
URL: https://github.com/apache/fineract/pull/6187#discussion_r4302289107
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/domain/JdbcSupport.java:
##########
@@ -65,6 +66,18 @@ public static LocalTime getLocalTime(final ResultSet rs,
final String columnName
return localTime;
}
+ public static OffsetTime getOffsetTime(final ResultSet rs, final String
columnName) throws SQLException {
+ try {
+ return rs.getObject(columnName, OffsetTime.class);
+ } catch (SQLException exception) {
Review Comment:
I tested the direct OffsetTime read end-to-end on MariaDB. Connector/J 3.5.8
does not support reading a TIME column as OffsetTime and throws an
SQLException, causing the savings transaction API to return 500. The UTC
LocalTime fallback is therefore required for MariaDB; PostgreSQL still reads
OffsetTime directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
