RusokeMarvin commented on PR #6685: URL: https://github.com/apache/fineract/pull/6685#issuecomment-6246592617
### Crucial Note for Reviewers regarding FINERACT-2034 Although JIRA ticket **FINERACT-2034** was previously marked as "Resolved," the previous patch only addressed the scenario where a `Loan Product` configuration itself is saved with incomplete template fields. It completely missed a secondary, critical execution path: when a **brand-new client with an empty borrowing history** (like a true first-time borrower) applies for a loan, the database query looking for historical records yields a `null` instead of an integer `0`. This unhandled `null` slips past the old fix and directly enters `LoanApplicationValidator.validateBorrowerCycle`, triggering the exact same fatal `NullPointerException` on line unboxing comparisons. This PR provides the definitive logic patch to ensure full null-safety across both the product configuration and the client-history data tracks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
