SamaSVM commented on PR #6376: URL: https://github.com/apache/fineract/pull/6376#issuecomment-6267789787
@galovics Thanks for the detailed review — I checked both points. **Staff/Charge API surface:** Confirmed, you're right. Staff and Charge are reachable through the `PostProvisioningCriteriaRequest` → `loanProducts[]` chain, so `isNotActive`, `isNotLoanOfficer`, and `isAllowedClientChargeTime` appear as `notActive`, `notLoanOfficer`, and `allowedClientChargeTime` in the generated schema. I pushed an update that removes these 4 items from this PR. The PR is now limited to `fineract-core`; `Charge.java` / `fineract-charge` are untouched. **MoneySerializer/MoneyDeserializer:** These are already dead code on current `develop`. `c7266fffaa` (FINERACT-2421) replaced the `new MoneySerializer()` / `new MoneyDeserializer(...)` usages with inline lambdas in both `ProgressiveLoanInterestScheduleModelParserGsonImpl` and `ProjectedAmortizationScheduleModelParserGsonImpl`. I also updated the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
