somasorosdpc opened a new pull request, #6690: URL: https://github.com/apache/fineract/pull/6690
## Description You’ll need a loan charge, %Amount, due at specific date. You’ll either add the charge to the loan product or to the loan account before approval/disbursement. ### Steps to reproduce: Create a loan with the above charge added. The loan must have progressive repayment schedule Disburse the loan #### Expected result: the loan has the charges calculated and added #### Actual result: loan misses the charges already added Note: it works correctly with cummulative loans. ### Root Cause After creating a percentage based due-date charge, charge is created based on the expected disbursements. Once the first real disbursement is created, the progressive transaction processor tries to recalculate all transactions, charges and term variations. During the progressive reprocessing, the charge calculation results 0 due the actual disbursed amount is 0. ### Solution Modify the transaction processing orders to avoid incorrect recalculations before first disbursement. Any operation processing should happen after the first disbursement ( this is necessary to keep transitive property of comparator ) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
