SamaSVM commented on PR #6377: URL: https://github.com/apache/fineract/pull/6377#issuecomment-6268728153
@galovics Thanks for catching the API break. I verified and fixed the issues: 1. **R009/R014 on `interestRateFrequencyTypeOptions`** — confirmed via `checkBreakingChanges` against the upstream/develop baseline. Restored the field and `toTemplate(...)` on `FloatingRateData`. The PR is non-breaking again. Note: there is no checked-in baseline file in this repo; the workflow generates it from the base branch in CI, so updating the baseline is not applicable here. 2. **`isIsDifferentialToBLR()`** — verified that responses are serialized via `DefaultToApiJsonSerializer` → Gson, which is field-based rather than getter-based. There is no generated schema for `InterestRatePeriodData` (hand-written Swagger DTOs are used instead), and there are no callers. Kept it removed. 3. **MapStruct** — confirmed there is no `@Mapper`/`org.mapstruct` usage in the module. Clean build passes. 4. **`retrieveAllActive` / `retrieveBaseLendingRate` / `getBaseLendingRatePeriods` / String constructor** — confirmed there are no callers on the current `develop`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
