CaptainAni187 opened a new pull request, #820:
URL: https://github.com/apache/fineract-backoffice-ui/pull/820
## What and why
The last column on SI History used `COMMON.ERROR` as its label, which is the
generic "Operation failed." toast text, so the screen looked like it failed on
every load. This adds a `COMMON.ERROR_LOG` key ("Error Log") and uses it for
that column.
I added it to `en`, `fr` and `hi`, using the same translation each file
already has for `REPORT_MAILING.ERROR_LOG`. `ko` doesn't have the `COMMON`
error keys yet, so it falls back to English like the other untranslated keys.
Closes #745
## Verification
- New `standing-instruction-history.component.test.ts` checks the column
uses `COMMON.ERROR_LOG` and that it reads "Error Log" in `en.json`. It doesn't
compile on main since the key doesn't exist there
- `npm run test:unit` passes, eslint and prettier are clean
- `npm run i18n:check` reports the same `fr.json`
`ON_HOLD_TRANSACTIONS.REASON` problem on main and on this branch, nothing new
## Screenshots
Not included, the only visible change is the header text.
## AI assistance (optional)
- Tool / model:
- Harness / workflow:
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [ ] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. (not a workflow change)
- [x] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
- [ ] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [x] If this adds a feature or changes a workflow, I raised it on
[[email protected]](https://lists.apache.org/[email protected])
first — or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
