rhopman commented on PR #6460: URL: https://github.com/apache/fineract/pull/6460#issuecomment-6266791499
Thanks for the detailed review, @galovics. Updated and force-pushed: - Added a progress guard: a returned due date must be strictly later than the previous one. An unchanged or backwards date stops that charge, allows unrelated charges to run, and makes the job fail. Tests cover both cases. - Kept the` LocalDate` return value because it now supports that progress check. Extracted `isDue(...)` to remove the duplicated predicate. - Removed `withChargeContext` so `getCauses()` preserves the original exception types. Charge, account, and installment context remain in the logs. - Removed the annotation-reflection test and extracted the shared scheduler success assertion. For the pool concern, I added PostgreSQL/Hikari tests using the existing Batch transaction fixture. When the outer transaction retains a connection, a one-connection pool times out; two connections allow the inner commit to survive an outer rollback. I’ve documented that sizing constraint in the connection-pool reference. This verifies the small-pool behavior, but I haven’t run a concurrent-job load test. Agreed that deposit-account charge processing warrants a separate follow-up; I’ve left it outside this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
