CaptainAni187 opened a new pull request, #822:
URL: https://github.com/apache/fineract-backoffice-ui/pull/822

   ## What and why
   
   The client charges and client collateral screens had routes but nothing on 
the client page linked to them, and New Account had no Share Account even 
though the share account form already reads `?clientId=`.
   
   This adds "Client Charges" and "Client Collateral" to the client's Actions 
menu (any status), and "Share Account" to New Account, which opens 
`/products/shares/create?clientId=<id>` the same way the deposit entries do.
   
   Charges is gated on `READ_CLIENTCHARGE` like its route, and I added that to 
the Actions button's permission list so a user who can only read charges still 
gets the menu. Collateral isn't gated, since its list route has no permission 
and there's no read code for client collateral in `permission-codes.json`. 
Share Account is gated on `CREATE_SHAREACCOUNT`.
   
   New key `ACTIONS.SHARE_ACCOUNT` in en, fr, hi and ko. The two menu labels 
reuse `CLIENT_CHARGES.TITLE` and `CLIENT_COLLATERAL.TITLE`.
   
   Closes #795
   
   ## Verification
   
   - Unit tests in `client-view.component.test.ts` for the three handlers.
   - A mocked e2e test in `e2e/client-accounts.spec.ts` opens both menus and 
follows each new item to its page. It fails on main.
   
   ## Screenshots
   
   Actions, before / after:
   
   ![actions 
before](https://raw.githubusercontent.com/CaptainAni187/fineract-backoffice-ui/pr-assets/795/actions-before.png)
   ![actions 
after](https://raw.githubusercontent.com/CaptainAni187/fineract-backoffice-ui/pr-assets/795/actions-after.png)
   
   New Account, before / after:
   
   ![new account 
before](https://raw.githubusercontent.com/CaptainAni187/fineract-backoffice-ui/pr-assets/795/new-account-before.png)
   ![new account 
after](https://raw.githubusercontent.com/CaptainAni187/fineract-backoffice-ui/pr-assets/795/new-account-after.png)
   
   ## AI assistance (optional)
   
   - Tool / model:
   - Harness / workflow:
   
   ## Checklist
   
   - [x] I did not hand-edit generated files under `src/app/api/`.
   - [x] New component or service code uses the adapter boundary in 
`src/app/core/adapters/` instead of direct browser globals or imperative 
third-party APIs.
   - [x] User-facing strings use translation keys.
   - [x] I added or updated tests appropriate to this change, or explained why 
tests were not needed.
   - [x] UI workflow changes include suitable e2e coverage, including 
real-backend testing where relevant.
   - [x] Commits are signed — see [Commit 
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
   - [ ] I followed the [AI-assisted contributions 
guidance](CONTRIBUTING.md#ai-assisted-contributions).
   - [x] If this adds a feature or changes a workflow, I raised it on 
[[email protected]](https://lists.apache.org/[email protected])
 first — or it is a bug fix, refactor or test change, where that does not apply.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to