budaidev opened a new pull request, #6696: URL: https://github.com/apache/fineract/pull/6696
## Description The validator accepted some delinquency pauses that overlap an existing pause, for example a second pause with the same start date and a later end date. The delinquency calculation then counted the shared days twice. The overlap check now treats the end date as exclusive and rejects a new pause when start < existingEnd && end > existingStart. This catches pauses with the same start, the same end, or one containing the other. Back-to-back pauses are still allowed. The check compares against the end date after any resume, and it skips a pause resumed on its own start date, because that pause covers no days. A RESUME now ends only the pauses created before it. Before this change, a resume on date D also cut short a pause created later that starts on D. That pause dropped to zero days, and new pauses could overlap it. A second RESUME on the same date is allowed only while a pause is still running on that date. The validator still rejects plain duplicates. The error response is the same as before, HTTP 400 with validation.msg.loanDelinquencyAction.overlapping. There is no migration and no API change. The resume rule applies whenever Fineract reads pause data, so it also changes existing loans. A pause created after a resume dated inside it now keeps its full end date. For those loans the pause period, the paused-day count and the delinquency classification at the next COB can change. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
