rymghosn opened a new pull request, #6718: URL: https://github.com/apache/fineract/pull/6718
## Description JIRA: [FINERACT-2984](https://issues.apache.org/jira/browse/FINERACT-2984) **Root cause.** `InteropServiceImpl.getAccountTransactions` loads the notes of each returned transaction with `noteRepository.findBySavingsTransactionId(Long.valueOf(interopTransactionData.getTransactionId()))`. `InteropTransactionData` extends `CommandProcessingResult` and only passes the entity id to `super(...)`, so the inherited `transactionId` is always `null`; the savings transaction id is held in the class's own `savingTransactionId` field. `Long.valueOf(null)` throws `NumberFormatException: Cannot parse null string` on the first transaction, so `GET /interoperation/accounts/{accountId}/transactions` answers 500 for every account that has a transaction matching the filter, and only works when the result is empty. **Fix.** Look the notes up by `getSavingTransactionId()`. **Tests.** New `InteropServiceImplTest.getAccountTransactions_shouldLookUpNotesBySavingsTransactionId` (one deposit with a note): fails on `develop` with `NumberFormatException: Cannot parse null string`, passes with the fix and checks the note is appended. `spotlessJavaCheck` clean. **Live check on a local stock instance** (`develop` `71c39730e9`, PostgreSQL), a savings account with an external id and one deposit: | request | develop | with this PR | |---|---|---| | `GET /interoperation/accounts/{externalId}/transactions?debit=true&credit=true` | 500, `NumberFormatException: Cannot parse null string` in the log | 200, the deposit is returned | | same, `fromBookingDateTime`/`toBookingDateTime` covering no transaction | 200, empty list | 200, empty list | No API change: same endpoint, same response shape. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
