Dhanno98 commented on PR #6448:
URL: https://github.com/apache/fineract/pull/6448#issuecomment-6346238703
> * Why is `{type}` still a path param on a "Share Account V2" resource?
Every caller passes `share` and it feeds `accountType.toUpperCase() +
"ACCOUNT"` as the entity name, so arbitrary strings reach the command
dispatcher. Hardcode it or validate it.
Agreed. I kept `{type}` because the existing command-processing flow is
based on the generic `accountType` parameter and I reused that flow in the V2
delegate. In this implementation, the endpoint is intended for share accounts
and every caller passes `share`, so exposing an arbitrary `{type}` is
unnecessary. If the V2 API were retained, I would either hardcode it or
validate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
