iammcoding commented on PR #6708: URL: https://github.com/apache/fineract/pull/6708#issuecomment-6360143925
@adamsaghy I noticed FINERACT-2940 / #6691 covers allowed values for global configurations more broadly. For context, this PR is a deliberately small fix (3 files, no API or schema change) for the three configurations where an invalid value breaks things at runtime today, which we hit running Fineract in production: - `outstanding-interest-calculation-strategy-for-external-asset-transfer` → `UnsupportedOperationException` during external asset transfers - `next-payment-due-date` → delinquency details silently return no next payment date - `charge-accrual-date` → silently treated as `due-date` It could go in as a quick, low-risk fix now, and #6691 can replace the validation with its enum-based approach when it lands. Happy to adjust whatever you prefer. The only failing checks (spotless, WAR smoke test) fail on the download.eclipse.org P2 outage, the same as on `develop`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
