Bhavya-Sonigra opened a new pull request, #6728: URL: https://github.com/apache/fineract/pull/6728
## Description In `DataValidatorBuilder`, the varargs overload `isOneOfTheseStringValues(final Object... values)` converts `this.value` to lowercase, but does not convert `rawValuesList` to lowercase. Consequently, if the allowed options contain uppercase or mixed-case characters (e.g. enum names or `"ACTIVE"`), the check `rawValuesList.contains(this.value.toString().toLowerCase())` performs a case-sensitive `String.equals()` check and always evaluates to `false`. This PR delegates the varargs overload `isOneOfTheseStringValues(Object... values)` directly to `isOneOfTheseStringValues(List<String>)`, eliminating the code duplication and ensuring consistent case-insensitive matching across both overloads. Comprehensive unit tests covering case-insensitivity, rejection of invalid values, and null handling have been added in `DataValidatorBuilderTest`. Associated Jira Ticket: [FINERACT-2987](https://issues.apache.org/jira/browse/FINERACT-2987) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
