Cocoa-Puffs opened a new pull request, #6756: URL: https://github.com/apache/fineract/pull/6756
## Description Re-aging a progressive, interest-bearing loan with `EQUAL_AMORTIZATION_PAYABLE_INTEREST` interest handling could leave amounts outstanding on installments that were due before the re-age date. Two independent defects caused this: **1. Deferred interest of an early-paid period was counted twice** With the `LAST_INSTALLMENT` future installment allocation rule, an early repayment fully pays off the last installment(s). The interest of a period paid in advance is not yet earned, so the interest model defers it to the last unpaid repayment period as future unrecognized interest. When the loan is re-aged after maturity, the equal amortization re-age closes all open repayment periods and moves their outstanding amounts, including the deferred interest, into the re-aged installments. The deferred interest was not cleared on the closed periods, though, so it reappeared as outstanding interest on a past-due installment and was charged twice. Fix: `ProgressiveEMICalculator.reAgeEqualAmortization` now resets the future unrecognized interest of every period it closes. **2. Waived / written-off charges produced negative outstanding amounts** `AdvancedPaymentScheduleTransactionProcessor.liftOutstandingBalances` moves outstanding fees and penalties of past installments onto the re-aged installments, then sets the charged amount of each past installment to its paid amount. Waived and written-off amounts were ignored, so an installment with a waived charge ended up with a negative outstanding balance. Fix: the charged amount is now set to paid + waived + written off, for both fees and penalties. The default re-age interest handling was checked against the same scenarios and is not affected by either defect. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
