oleksii-novikov-onix commented on PR #6720: URL: https://github.com/apache/fineract/pull/6720#issuecomment-6465571197
> The logic looks right to me: evaluation dates go through the same shared pause rule the schedule uses, starting from the stored period `fromDate`, so grace-day pauses, resumed pauses and restart resets behave like the period end. > > One request: the three unit-test classes only pad the parameters with `List.of(), List.of()`, so the pause logic is covered only by the extended e2e scenarios. Can we add a focused unit test for evaluation dates moved by a pause? > > I'll approve once the PR is out of draft and CI (including the e2e matrix, since the new expected values are unproven until it runs) is green. > > Not for this PR, just noting it: grace days are added to the evaluation start of every period, while the schedule adds them only to the first period's end. 1. Add a focused unit test for evaluation dates shifted by a pause - done. 2. Align grace-day handling across periods - unchanged. I agree that this is outside the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
