AshharAhmadKhan commented on PR #6494: URL: https://github.com/apache/fineract/pull/6494#issuecomment-6477995276
Thanks @adamsaghy and @galovics, reworked as agreed. I dropped the lifter and its tests and stopped wrapping the user report SQL. **Changes** - `buildPreparedQuery` no longer calls `wrapSQL`. The two parameter lookup callers are unchanged. - `fillGenericResultSet` now reads headers with `getColumnLabel`. - `fillResultsetRowData` now reads values by position (`rs.getObject(i + 1)`), so two aliased columns from the same source column keep their own values. - `ReportsTest` has a new integration test. The report orders by `a.id DESC, b.id DESC`, which differs from primary key order, and selects `a.id AS first_id` and `b.id AS second_id`, two aliased columns from the same source column. **Behavior change** Report SQL that the wrapper used to reject (a trailing `;`, statements that are not a `SELECT`) will now run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
