DeathGun44 opened a new pull request, #6774: URL: https://github.com/apache/fineract/pull/6774
## Description FINERACT-2967: last PR of the Feign migration (row 14 of FINERACT-2609). It moves the remaining test code from REST Assured and the Retrofit client to the Feign client, deletes the legacy helpers, and removes REST Assured from the build. - The shared test extensions and the global configuration, delinquency, client, payment type and fund helpers now use Feign. - Migrated `DateValidationTest`, the three share tests, `InteropTest`, `FloatingRateInterestRecalculationTest`, `OAuth2AuthenticationTest` and `TwoFactorAuthenticationTest`. - `InteropTest` balance checks read a field the response does not have (null vs null). They now check the available balance. - Swagger fixes: fixed deposit `charges`, share dividend and share fields, interop path fields, floating rate loan product fields, and the two-factor endpoints. - `FineractFeignClient.Builder.withoutCredentials()` builds a client that sends no Basic header (for OAuth2 tokens and unauthenticated calls). - The e2e batch reschedule "with created user" steps send that user's credentials again; an earlier migration dropped them. - REST Assured is removed from all modules, the test modules no longer use the Retrofit client, and the checkstyle ban now has no exemptions. `fineract-client` and the Retrofit webhook code are unchanged. No test is removed; every migrated test keeps its checks. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/disze+Limit). Largechanges can be made in a branch, with assistance. Ask for help on the [developerlist](https://fineract.apache.org/#contribute). - [x] If merging , I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed b.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
