adamsaghy commented on PR #6736: URL: https://github.com/apache/fineract/pull/6736#issuecomment-6483615123
The change looks right, and reusing the deposit/withdraw reversal keeps the behaviour consistent. Could you add tests for the missing paths? 1. An integration test for one of the JIRA cases: accrual product, deposit, run the accrual job, undo the transaction, then assert that Interest Payable returns to 0 and that the reversed accruals have reversal journal entries. 2. Coverage of the reverse-transaction API path (`handleReversal` -> `undoTransaction(SavingsAccountTransaction)`), ideally with the pivot-date config on. The current unit tests only reach `undoTransaction(Long)` and `undoSavingsTransaction(Long)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
