adamsaghy commented on PR #6761:
URL: https://github.com/apache/fineract/pull/6761#issuecomment-6483632623

   Thanks for the rebase. Two things are still missing before this can be 
merged:
   
   1. **PR description**: it is still the empty template. Please describe what 
changes and why: the Post Interest job now splits an interest posting that pays 
down an overdraft, crediting the overdraft part to Overdraft Portfolio Control 
and the rest to Savings Control.
   2. **The open accounting question from FINERACT-2909**: the ticket asks 
which account to debit on accrual products, and right now that is settled only 
in a code comment. The job debits Interest Payable for both parts, while the 
manual path (`AccrualBasedAccountingProcessorForSavings`) debits Interest on 
Savings, so the two paths will keep producing different entries. Please record 
the decision on the JIRA (and in the PR description), so reviewers can confirm 
the intended behaviour.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to