adamsaghy commented on PR #6763: URL: https://github.com/apache/fineract/pull/6763#issuecomment-6483708688
I checked the scripts, workflows and changelog examples against develop and they match, nice work. One small thing: the example `0274_add_x_to_m_savings_account.xml` uses core-tree numbering for a savings table, while rule 1 and current practice (`savings/parts/parts/2003`, `2004`) put such changes in the savings module tree. Could you pick an example from a core-owned table? Please also reply to IOhacker's open question about non-Claude agents (`.agents/skills` is the agent-neutral location), and rebase onto develop: the build-core failure comes from `LoanApplicationTermsTest`, which #6765 already fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
