Abhishek6122008 opened a new pull request, #6782: URL: https://github.com/apache/fineract/pull/6782
With overdraft allowed and an Interest Receivable GL account mapped, each posting interval is calculated as two periods, one for the days in credit and one for the overdrawn days. They were calculated one after the other, so the second got the interest of the first compounded into all its days, before the end of the compounding period it was earned in. An account that went overdrawn during a month earned savings interest for the overdrawn days and was charged no overdraft interest. Calculate the two periods one compounding period at a time and compound the interest of both at its end, as for an interval that is not split. Daily compounding keeps adding the first period's interest to the second, since it compounds every day. SavingsAccountOverdraftInterestSplitTest stubbed a getter the service no longer reads, so its split cases ran without the split; it now stubs hasInterestReceivableMapping. ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
