pwargulak commented on PR #6753: URL: https://github.com/apache/fineract/pull/6753#issuecomment-6502626914
Thanks for the review. Both done: 1. Updated the comments. `COBBusinessStepServiceImpl#run` now says it joins the per-loan transaction opened by `ItemTransactionProcessor`, where the business-step writes, the last closed business date and the lock release commit or roll back together. In both worker configurations the no-task-executor note now gives the reason that still holds: the COB context (action context, COB and business dates) is thread-local and set on the step thread only, by the step listener's `beforeStep`. Concurrency still comes from partitioning. 2. There was no way to read a Working Capital lock from an integration test, so I added a test-profile-only `GET /v1/internal/working-capital-loans/locked` to `InternalWorkingCapitalAccountLockApiResource`, next to its `place-lock`. `FeignWorkingCapitalLoanCobBusinessStepFailureTest` now asserts that the failed loan's lock carries the error and that the closed loan's lock is gone, the same checks as the Loan COB test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
