Bhavya-Sonigra opened a new pull request, #6794:
URL: https://github.com/apache/fineract/pull/6794
## Description
As part of the ongoing **FSIP-5** architectural modernization initiative,
this PR migrates the GL Closure (accounting closure) write requests from the
legacy untyped command pipeline (`JsonCommand`, `CommandWrapper`,
`PortfolioCommandSourceWritePlatformService`) to the typed `CommandDispatcher`
infrastructure in `fineract-command`.
### Key Changes:
- **Request & Response DTOs**: Added strongly-typed DTOs in
`org.apache.fineract.accounting.closure.data` (`GLClosureCreateRequest`,
`GLClosureUpdateRequest`, `GLClosureDeleteRequest`, and corresponding
responses).
- **Typed Commands & Handlers**:
- Implemented `GLClosureCreateCommand`, `GLClosureUpdateCommand`, and
`GLClosureDeleteCommand` extending `Command<Request>`.
- Implemented dedicated `@CommandHandler` beans in
`org.apache.fineract.accounting.closure.handler`
(`GLClosureCreateCommandHandler`, `GLClosureUpdateCommandHandler`,
`GLClosureDeleteCommandHandler`).
- **REST Resource**: Refactored `GLClosuresApiResource` to inject
`CommandDispatcher` and synchronously dispatch commands
(`dispatcher.dispatch(command).get()`).
- **Service Layer**: Refactored `GLClosureWritePlatformService` and its JPA
repository implementation to accept typed request DTOs directly, eliminating
dependencies on `JsonCommand` and `FromJsonHelper`.
- **Security**: Added endpoint route authorization rules in `SecurityConfig`
for `CREATE_GLCLOSURE`, `UPDATE_GLCLOSURE`, and `DELETE_GLCLOSURE`.
- **Legacy Cleanup**:
- Removed obsolete `GLClosureCommandFromApiJsonDeserializer` and internal
`GLClosureCommand` record.
- Removed legacy GL closure builder methods from `CommandWrapperBuilder`
and `CommandWrapperConstants`.
- **Test Coverage**:
- Added unit tests for `GLClosuresApiResourceTest` (all CRUD routes).
- Added unit tests for all three command handlers
(`GLClosureCreateCommandHandlerTest`, etc.).
- Added comprehensive test suite for
`GLClosureWritePlatformServiceJpaRepositoryImplTest` covering creation,
updates, deletions, and business validation rules.
- Verified with `AccountingCrossFeatureBoundaryTest`, Spotless,
Checkstyle, and Apache RAT.
Jira issue:
[FINERACT-3021](https://issues.apache.org/jira/browse/FINERACT-3021)
## Checklist
- [x] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [x] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [x] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
