nihalritgithub opened a new pull request, #189: URL: https://github.com/apache/fineract-loan-origination/pull/189
Fixes #161. Recreates the previously reviewed and approved PR #171, which was closed due to inactivity and pending merge conflicts. The branch has now been synchronized with the latest upstream `main`, and the conflicts have been resolved while preserving existing security-related exception handling. ### Changes - Handle `MethodArgumentNotValidException` with HTTP 400 and field-level validation errors. - Handle `HandlerMethodValidationException` with HTTP 400 for invalid request parameters, while preserving HTTP 500 for return-value validation failures. - Handle `HttpMessageNotReadableException` with HTTP 400 for malformed JSON and incompatible field types. - Preserve existing error response structure, HTTP status mappings, and upstream access-denied handling. - Include regression tests for invalid amounts, currency, applicant data, numeric conversion, service-layer isolation, and existing behavior. ### Verification - Focused regression tests: **44 passed, 0 failures, 0 errors, 0 skipped**. - `spotless:apply` and `spotless:check` passed. - `apache-rat:check` passed. - Git whitespace check passed. - Full Docker-backed integration suite not run. - No frontend changes. ### Previous Review The original implementation was reviewed and approved by @KRYSTALM7 and @Aman-Mittal in #171. Review feedback was incorporated previously, and the latest upstream merge conflicts have now been resolved. Ready for renewed review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
