Aman-Mittal opened a new pull request, #844:
URL: https://github.com/apache/fineract-backoffice-ui/pull/844

   Both of these were reported in #825 and deliberately left out of it. Neither 
is urgent; both are small enough that carrying them as known noise costs more 
than fixing them.
   
   ## 1. `platform-date.service.test.ts` failed at UTC+14
   
   `prefers the platform clock over the browser clock` asserted the literal 
`'2026-08-15'` against a service that, with no tenant timezone configured, 
renders the recorded instant in the browser's own zone — deliberately, since 
there is no other zone to render it in. That made the runner's UTC offset part 
of the assertion:
   
   ```
   AssertionError: expected '2026-08-16' to be '2026-08-15'
   ```
   
   at `Pacific/Kiritimati`, where `10:00Z` is already the 16th. The service was 
behaving exactly as designed. CI runs at UTC so this never fired there, which 
is why it was not part of main being red.
   
   It now asserts the local rendering of the platform's *own* instant, and 
moves the browser's clock to a different day with fake timers, so the case 
still fails if the service ever reads `new Date()` in place of what the 
platform last said. That regression is the one it exists to catch, and against 
the real clock it caught it only by the accident of two dates differing.
   
   Green at `UTC`, `America/New_York`, `Asia/Kolkata` and UTC+14.
   
   ## 2. The last `import/no-duplicates` warnings
   
   Three product forms import `core/adapters` twice, once for `TranslatePipe` 
and again for `I18N` — six warnings, and the whole of what remains of that rule 
in the repository. Merged, as the clients-side cleanup in #839 did. `npm run 
lint` is down to the four pre-existing `security/*` warnings in 
`quartz-cron.ts`.
   
   ## Checks
   
   - `platform-date.service.test.ts` 18/18 at `UTC`, `America/New_York`, 
`Asia/Kolkata` and UTC+14
   - `lint` 0 errors, `eslint-suppressions.json` unchanged, `format:check` 
clean on tracked files, `tsc` clean
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to