a-mikh commented on code in PR #173:
URL:
https://github.com/apache/fineract-loan-origination/pull/173#discussion_r4433171110
##########
src/main/java/org/apache/fineract/los/api/AdminStaffController.java:
##########
@@ -64,7 +64,7 @@ public class AdminStaffController {
public record CreateStaffRequest(
@NotBlank String username,
- @NotBlank @Size(min = 8, message = "Password must be at least 8
characters") String password,
+ @NotBlank String password,
Review Comment:
Added password validation to updateStaff() before modifying the entity,
hashing, or saving. It uses the stored username and the new email when
provided, otherwise the stored email. A null password leaves the existing
password unchanged.
Removed the old @Size(min = 8) constraint and added service and API tests
for the update path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]