saidhanushae commented on PR #231: URL: https://github.com/apache/fineract-consumer-facing/pull/231#issuecomment-6554678170
Thanks for the review @Aman-Mittal! I have rebased onto main and updated the PR to address all comments: Rebased onto main so the ShrinkOnlyViolationStore diff only removes the 17 SavingsQueryServiceImpl entries. Refactored SavingsFineractClient and SavingsFineractClientImpl to follow the LoansQueryFineractClient pattern (listClientSavingsAccounts, getAccount, getCharges, searchTransactions, getTransaction, listSavingsProducts, getSavingsProduct), moving LOCALE, DATE_FORMAT, and Fineract transport defaults into the adapter. Restored the original import order, .map(...) continuation indentation, and trailing newlines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
