alberto-art3ch opened a new pull request, #6801:
URL: https://github.com/apache/fineract/pull/6801
## Description
`DatatableWriteServiceImpl.updateDatatable` wraps the `changeColumns` DDL in
a `catch (Exception e)` that only
rethrows when the message contains the MySQL texts "Error on rename" or
"invalid use of null value". Every other
failed ALTER was swallowed and the command continued as if it had succeeded:
- MariaDB / MySQL: DDL auto-commits, so the client got `200` and the column
was never renamed.
- PostgreSQL: the transaction was already aborted, so the next statement
failed with an unrelated error. Today that
statement happens to be the maker-checker configuration lookup, which gets
mapped to `403`; as soon as anything
changes the order of statements after the handler (for instance a
configuration cache that is warm, see #6493)
the audit save fails first and the client gets a raw `500`.
Change: the inner catch keeps the two message checks and rethrows everything
else. The exception is then mapped as
in every other datatable DDL path (`ErrorHandler.getMappable` ->
`PlatformDataIntegrityException`, `403`), which is
what the add-column path already answers for the same reserved name. The
catch is narrowed to `RuntimeException`,
which is all the block can throw.
Test: `FeignDatatableRenameToReservedColumnTest` creates an `m_client`
datatable with a `note` column, renames it to
`client_id` (the foreign-key column, so the ALTER fails), expects `403` with
a data-integrity error and checks that
both columns are still there. Before the change the test fails with `200` on
MariaDB/MySQL and `500` on PostgreSQL.
[FINERACT-2968](https://issues.apache.org/jira/browse/FINERACT-2968)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [ ] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
