DhroovSankla opened a new pull request, #6804:
URL: https://github.com/apache/fineract/pull/6804

   ## Description
   
   This PR removes the `@Deprecated(forRemoval = true)` `getChanges()` method 
and its associated unused Jackson and Map imports from 
`CurrencyUpdateResponse.java` 
([FINERACT-3028](https://issues.apache.org/jira/browse/FINERACT-3028)).
   
   **Context & API Impact:**
   - **API Impact:** Removes the legacy `"changes"` property wrapper from the 
JSON response payload. External clients should consume the strongly-typed 
`currencies` list directly.
   - **Code Health:** Eliminates unneeded `Map<String, Object>` response 
serialization, completing the technical debt removal outlined in the inline 
source comment.
   - Zero internal callers were found or impacted across the repository.
   
   ## Checklist
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to