adamsaghy commented on PR #6800: URL: https://github.com/apache/fineract/pull/6800#issuecomment-6604579671
Thanks, this looks good to me. The check runs before `client.activate(...)` and `openSavingsAccount(...)`, `ActivateClientCommandHandler` is the only path into `activateClient`, and it matches how the deposit account activation fix was done. Notes for follow-up (not blocking this PR): 1. **Creating a client with `active=true`**: as you noted, `createClient` with `active=true` and a default savings product also opens a funded savings account without checking that the chosen office is in the user's hierarchy. Please raise a separate ticket under FINERACT-2982 for it, since the fix changes who can create clients in other offices and needs its own release note. 2. **Swagger wording**: the `savingsProductId` description says the account is opened "when the client is activated". It is also opened when the client is created with `active=true`, so "when the client is activated (or created active)" would be more accurate. 3. **Checklist**: the `apiLive.htm` item is ticked but the file isn't changed. Your note explains why, so that's fine. Just mentioning it so the checklist matches the diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
