Bhavya-Sonigra commented on PR #6846:
URL: https://github.com/apache/fineract/pull/6846#issuecomment-6709279647
Hi @galovics,
Thank you for the thorough review and constructive feedback! All points have
been addressed in the latest update:
1. **Delegation Layer & 2-Step Approach:**
- A 2-step approach makes complete sense. Step 1 (this PR) focuses on a
clean, faithful service extraction with zero risk of breaking callers via
forwarding.
- As suggested, I will create a dedicated follow-up subtask under
[FINERACT-3147](https://issues.apache.org/jira/browse/FINERACT-3147) to rewire
the command handlers directly to `LoanTransactionWritePlatformService` and drop
the deprecated forwarders from `LoanWritePlatformService`.
2. **Deduplication of Helper Methods:**
- **`checkClientOrGroupActive`**: Removed the duplicate private
implementations in both `LoanTransactionWritePlatformServiceImpl` and
`LoanWritePlatformServiceJpaRepositoryImpl`; both now call
`this.loanUtilService.checkClientOrGroupActive(loan)`.
- **`createNote`**: Centralized note creation in `LoanUtilService`
(implementing `ILoanUtilService`), reusing its existing `NoteRepository`.
- **`saveAndFlushLoanWithDataIntegrityViolationChecks`**: Enhanced
`LoanAccountServiceImpl` to persist `loan.getRepaymentScheduleInstallments()`
before flushing (preserving the EclipseLink workaround), and updated both
services to delegate to
`loanAccountService.saveAndFlushLoanWithDataIntegrityViolationChecks(loan)`.
- Removed unused fields (`loanRepaymentScheduleInstallmentRepository`,
`loanRepositoryWrapper`, `noteRepository`) from
`LoanTransactionWritePlatformServiceImpl`.
3. **`handleChargebackTransaction`:**
- Removed from `LoanWritePlatformServiceJpaRepositoryImpl` along with its
delegation test.
- Removed from `LoanTransactionWritePlatformService` interface and made
package-private in `LoanTransactionWritePlatformServiceImpl`.
Could you please approve and trigger the GitHub Actions workflow when you
have a moment? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
