[
https://issues.apache.org/jira/browse/FINERACT-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18140200#comment-18140200
]
Shubham Chaudhary commented on FINERACT-3125:
---------------------------------------------
i am working on this issue :)
> Move loan product mix and loan product API classes to fineract-loan
> -------------------------------------------------------------------
>
> Key: FINERACT-3125
> URL: https://issues.apache.org/jira/browse/FINERACT-3125
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Adam Saghy
> Priority: Major
> Labels: beginner, beginner-friendly
>
> Move {{portfolio/loanproduct/productmix}} (21 files) and the remaining
> {{portfolio/loanproduct}} api, service, serialization and starter classes (5
> files) from {{fineract-provider/src/main/java/org/apache/fineract/}} to
> {{fineract-loan}}.
> h3. Done when
> * The listed classes live in the target module and {{fineract-provider}} no
> longer contains them.
> * Package names stay the same unless the PR explains why not (this keeps
> imports and Spring component scanning stable).
> * Where a moved class needs something that stays in provider, it depends on
> an interface in {{fineract-core}} (or in the target module) instead, with the
> implementation left in provider.
> * No new dependency from a feature module on {{fineract-provider}}; no cyclic
> module dependencies.
> * {{./gradlew build -x test}} passes and the existing unit, Cucumber and
> integration tests pass with no behaviour change.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
