Eyad-Sharkawy opened a new pull request, #6849: URL: https://github.com/apache/fineract/pull/6849
## Description Following the architectural initiative to decouple calculations and extensive logic from domain entities: `SavingsAccount.calculateDateAccountIsLockedUntil` computed the lock-in expiration date inside the entity using period frequencies (DAYS, WEEKS, MONTHS, YEARS). As a pure date computation, this logic does not belong inside the JPA entity. This PR: 1. Extracts `calculateDateAccountIsLockedUntil` into a stateless `SavingsAccountLockPeriodCalculator`. 2. Updates `SavingsAccount` to delegate to this calculator during account activation. 3. Adds comprehensive unit tests in `SavingsAccountLockPeriodCalculatorTest` covering all period frequency types, leap year edge cases, and null/invalid inputs. ## Related Issue https://issues.apache.org/jira/browse/FINERACT-3200 ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (N/A - internal refactoring, no API changes) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
