[
https://issues.apache.org/jira/browse/FINERACT-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18138407#comment-18138407
]
Abhishek Chaudhary edited comment on FINERACT-3174 at 11/5/26, 12:22 AM:
-------------------------------------------------------------------------
[~adamsaghy] id like to work on this as well
was (Author: JIRAUSER313349):
[~adamsaghy]id like to work on this as well
> Move interest and balance calculations out of savings entities
> --------------------------------------------------------------
>
> Key: FINERACT-3174
> URL: https://issues.apache.org/jira/browse/FINERACT-3174
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Adam Saghy
> Priority: Major
> Labels: beginner, beginner-friendly
>
> {{SavingsAccount}} (3,840 lines), {{SavingsAccountTransaction}} (973) and
> {{SavingsAccountCharge}} (953) in {{fineract-savings}} contain interest
> calculation, posting-period and running-balance logic. Move it into
> calculators or services (for example next to
> {{SavingsAccountInterestPostingServiceImpl}}). Leave the entities with state
> and state-changing methods.
> h3. Done when
> * The entity only holds state and the methods that change that state
> consistently (for example {{activate(date)}} or {{updateName(name)}}).
> * Parsing, request validation and calculations live in services, validators,
> assemblers or calculators, which are unit tested.
> * No behaviour change; validation error codes and messages stay the same;
> existing tests pass.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
