[ https://issues.apache.org/jira/browse/FINERACT-3187 ]
Swati Shaw deleted comment on FINERACT-3187:
--------------------------------------
was (Author: JIRAUSER315365):
[~adamsaghy] Hi, I’m interested in working on this issue. I would like to take
this up and contribute the required changes. Could you please assign this issue
to me?
> Return typed objects from code, office, holiday and configuration API
> resources
> -------------------------------------------------------------------------------
>
> Key: FINERACT-3187
> URL: https://issues.apache.org/jira/browse/FINERACT-3187
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Adam Saghy
> Priority: Major
> Labels: beginner, beginner-friendly
>
> Convert the String-returning methods of these resources (35 methods):
> * {{CodesApiResource}} (6)
> * {{CodeValuesApiResource}} (5)
> * {{OfficesApiResource}} (6)
> * {{OfficeTransactionsApiResource}} (4)
> * {{HolidaysApiResource}} (7)
> * {{GlobalConfigurationApiResource}} (5)
> * {{ExternalServicesConfigurationApiResource}} (2)
> h3. How
> * Change the method's return type from {{String}} to the response DTO (or a
> list of it) and return the object. JAX-RS/Jackson then serializes it, as the
> {{fineract-accounting}} resources (for example {{GLAccountsApiResource}})
> already do.
> * Remove the now unused {{DefaultToApiJsonSerializer}} /
> {{ToApiJsonSerializer}} fields and {{RESPONSE_DATA_PARAMETERS}} constants.
> * Keep {{fields}}, template and other query-parameter behaviour, following
> the existing typed resources.
> h3. Done when
> * The JSON responses are unchanged: field names, date and number formats,
> nulls and the {{fields}} filter. Integration tests and the Feign-client tests
> pass.
> * The generated OpenAPI spec and the {{fineract-client}} /
> {{fineract-client-feign}} method names do not change.
> * No behaviour change.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
