adamsaghy opened a new pull request, #6831: URL: https://github.com/apache/fineract/pull/6831
## Description Fixes the `ClientSavingsIntegrationTest` failures on `develop` in `run-integration-tests-sequentially-on-postgresql` ([run](https://github.com/apache/fineract/actions/runs/41887076605/job/126787366748)). There are five failures: `testRunningBalanceAfter*WithBackdateConfigurationOn` (4) and `testToPerformTransactionBeforePivotDate`. All five fail with `Job status is not success for jobId=6`. **Cause.** With `allow-backdated-transaction-before-interest-posting` disabled (pivot date mode), `SavingsAccountWritePlatformServiceJpaRepositoryImpl.postInterest` skipped `selectAccountId` for new postings. This came from an `if (!backdatedTxnsAllowedTill)` guard added in 2022. The job's batch journal entry insert then wrote `account_id = null` for every savings product with accounting. The CI database log shows it on each failure: ``` ERROR: null value in column "account_id" of relation "acc_gl_journal_entry" violates not-null constraint ``` The entry was for savings account 3, which an earlier test class left behind. Before #6620 the job swallowed worker exceptions, so the failed sub-batch rolled back without anyone noticing. #6620 makes the job report it, so the tests now fail. **Fix.** Choose the GL accounts for new postings in both modes. **Tests** - `SavingsAccountWritePlatformServiceJpaRepositoryImplTest`: a parameterized test checks the GL accounts are set with the pivot config on and off. Without the fix, the "on" case fails. - `SavingsAccrualAccountingIntegrationTest.testPostInterestJobPostsAccrualJournalEntriesWithPivotDateConfiguration`: an accrual product with the pivot config on. Locally on the PostgreSQL Docker stack it fails at the base commit with the same `account_id` error, and passes with the fix. The five `ClientSavingsIntegrationTest` tests also pass with the fix. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
