Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/199#discussion_r74540135
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java
---
@@ -820,11 +820,12 @@ private void createCreditJournalEntryForSavings(final
Office office, final Strin
SavingsAccountTransaction savingsAccountTransaction = null;
ClientTransaction clientTransaction = null;
final Long shareTransactionId = null;
- final PaymentDetail paymentDetail = null;
+ PaymentDetail paymentDetail = null;
String modifiedTransactionId = transactionId;
if (StringUtils.isNumeric(transactionId)) {
long id = Long.parseLong(transactionId);
savingsAccountTransaction =
this.savingsAccountTransactionRepository.findOne(id);
+ paymentDetail =
this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --
unnecessary repository call. You can make use of savingsAccountTransaction
object to retrieve payment details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
