Github user ad-os commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/270#discussion_r96020429
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/notification/data/NotificationData.java
 ---
    @@ -0,0 +1,220 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements. See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership. The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License. You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied. See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.fineract.notification.data;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class NotificationData implements Serializable {
    +
    +    private Long id;
    +    private Long userId;
    +    private String objectType;
    +    private Long objectId;
    +    private String action;
    +    private String actor;
    +    private String content;
    +    private boolean isSystemGenerated;
    +    private String tenantIdentifier;
    +    private String createdAt;
    +    private Long officeId;
    +    private List<Long> userIds;
    +
    +    public NotificationData() {
    +
    +    }
    +
    +    public NotificationData(NotificationBuilder builder) {
    +        this.userId = builder.userId;
    +        this.objectType = builder.objectType;
    +        this.objectId = builder.objectId;
    +        this.action = builder.action;
    +        this.actor = builder.actor;
    +        this.content = builder.notificationContent;
    +        this.isSystemGenerated = builder.isSystemGenerated;
    +        this.tenantIdentifier = builder.tenantIdentifier;
    +        this.userIds = builder.userIds;
    +        this.officeId = builder.officeId;
    +    }
    +
    +    public Long getOfficeId() {
    +        return officeId;
    +    }
    +
    +    public void setOfficeId(Long officeId) {
    +        this.officeId = officeId;
    +    }
    +
    +    public List<Long> getUserIds() {
    +        return userIds;
    +    }
    +
    +    public void setUserId(List<Long> userIds) {
    +        this.userIds = userIds;
    +    }
    +
    +    public Long getId() {
    +        return id;
    +    }
    +
    +    public void setId(Long id) {
    +        this.id = id;
    +    }
    +
    +    public String getCreatedAt() {
    +        return createdAt;
    +    }
    +
    +    public void setCreatedAt(String createdAt) {
    +        this.createdAt = createdAt;
    +    }
    +
    +    public Long getUserId() {
    +        return userId;
    +    }
    +
    +    public void setUserId(Long userId) {
    +        this.userId = userId;
    +    }
    +
    +    public String getObjectType() {
    +        return objectType;
    +    }
    +
    +    public void setObjectType(String objectType) {
    +        this.objectType = objectType;
    +    }
    +
    +    public Long getObjectIdentfier() {
    +        return objectId;
    +    }
    +
    +    public void entifier(Long objectIdentifier) {
    +        this.objectId = objectIdentifier;
    +    }
    +
    +    public String getAction() {
    +        return action;
    +    }
    +
    +    public void setAction(String action) {
    +        this.action = action;
    +    }
    +
    +    public String getActor() {
    +        return actor;
    +    }
    +
    +    public void setActor(String actor) {
    +        this.actor = actor;
    +    }
    +
    +    public String getContent() {
    +        return content;
    +    }
    +
    +    public void setContent(String content) {
    +        this.content = content;
    +    }
    +
    +    public boolean isSystemGenerated() {
    +        return isSystemGenerated;
    +    }
    +
    +    public void setSystemGenerated(boolean systemGenerated) {
    +        isSystemGenerated = systemGenerated;
    +    }
    +
    +    public String getTenantIdentifier() {
    +        return tenantIdentifier;
    +    }
    +
    +    public void setTenantIdentifier(String tenantIdentifier) {
    +        this.tenantIdentifier = tenantIdentifier;
    +    }
    +
    +    public static class NotificationBuilder {
    --- End diff --
    
    Hi,
    The use of this static class is only in `NotificationData` class. I have 
used this static inner class to implement a builder pattern. Is it advisable to 
move to another file ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to