[ 
https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277684#comment-14277684
 ] 

ASF GitHub Bot commented on FLINK-1402:
---------------------------------------

Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/306#issuecomment-69992202
  
    I don't remember if there any best practice about this, so If we think it 
is useful we could keep this style and maybe document it?
    But I don't think it is good practice for other interfaces.


> Remove extra extend Serializable in InputFormat interface
> ---------------------------------------------------------
>
>                 Key: FLINK-1402
>                 URL: https://issues.apache.org/jira/browse/FLINK-1402
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
>
> The org.apache.flink.api.common.io.InputFormat currently defined as:
> public interface InputFormat<OT, T extends InputSplit> extends 
> InputSplitSource<T>, Serializable
> however, InputSplitSource already extend Serializable:
> public interface InputSplitSource<T extends InputSplit> extends Serializable
> so no need for InputFormat to explicitly extend Serializable interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to