[ 
https://issues.apache.org/jira/browse/FLINK-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281923#comment-14281923
 ] 

Henry Saputra commented on FLINK-655:
-------------------------------------

So, the option are:
1. Use this JIRA as vehicle to add new APIs to add set or individual broadcast 
variable. This will break API compatibility for 0.9 release.
2. Use this JIRA to deprecate use of existing one and promote new ones of 
withBroadcastVariable and getBroadcastVariable for just naming consistency.
3. Do nothing for now and close this one as will not fix.

Actually since both methods are called from different contexts, one is from 
RuntimeContext and the other from Operator, different names should not annoy 
customers that much.

> Add support for both single and set of broadcast values
> -------------------------------------------------------
>
>                 Key: FLINK-655
>                 URL: https://issues.apache.org/jira/browse/FLINK-655
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>            Reporter: Ufuk Celebi
>            Assignee: Henry Saputra
>              Labels: breaking-api, github-import, starter
>             Fix For: pre-apache
>
>
> To broadcast a data set you have to do the following:
> ```java
> lorem.map(new MyMapper()).withBroadcastSet(toBroadcast, "toBroadcastName")
> ```
> In the operator you call:
> ```java
> getRuntimeContext().getBroadcastVariable("toBroadcastName")
> ```
> I propose to have both method names consistent, e.g.
>   - `withBroadcastVariable(DataSet, String)`, or
>   - `getBroadcastSet(String)`.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/655
> Created by: [uce|https://github.com/uce]
> Labels: enhancement, java api, user satisfaction, 
> Created at: Wed Apr 02 16:29:08 CEST 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to