Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70803368
I would like to respect Vasia's suggestion for the library name - she has
bootstrapped the whole thing, after all.
Personalized names are actually something good, in my opinion (spargel was
along the same lines), and we can think about continuing that with the ML
library name.
As for the merging / rebasing:
- The script I created for the streaming code was there mainly to
linearize the commit history, as rebasing had forced us to redo all merges.
If gelly has a linear history, that is not needed.
- Since the code base is completely independent, the adding rebase may be
simple. First rename all gelly files to be in the directory where they
should end up (flink-addons/...) and then simply rebase onto the flink
master
On Tue, Jan 20, 2015 at 11:42 PM, Paris Carbone <notificati...@github.com>
wrote:
>
> +1 for Gelly :)
> It's good to personalize flink libraries somehow, people remember these.
> Though, to be honest, it would be more consistent in that case if other
> add-ons also had names with a certain theme perhaps instead of
> Flink-<insert formal component definition>
>
> > On 21 Jan 2015, at 02:13, Kostas Tzoumas <notificati...@github.com>
> wrote:
> >
> > I think Gelly has way more personality than flink-graph
> >
> > â
> > Reply to this email directly or view it on GitHub.
> >
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/326#issuecomment-70796718>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
