Github user StephanEwen commented on commit 
7df6a3d7266b0f934b76722732176dbf5469bdb4:

    
https://github.com/apache/flink/commit/7df6a3d7266b0f934b76722732176dbf5469bdb4#commitcomment-9381873
  
    In 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java:
    In 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java
 on line 453:
    This seems a bit wrong here. The caller calls the `next()` function, which 
creates an element (potentially large) to pass it to the `next(T reuse)` 
function, which in turn ignores the value.
    
    I would move the logic to the `next()` function and have the `next(T 
reuse)` function simply call the `next()` function, ignoring any reusable 
element.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to