Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/319#issuecomment-71455790
  
    This is a huge change. I took a look over the code, but I don't have enough 
experience with the scheduler to understand these changes.
    
    I would suggest to merge this rather soon because its touching a lot of 
code due to minor scala style changes (semicolons, removal of parentheses from 
no-arg methods, unneeded { } and so on)
    +1 for the added documentation to the classes!
    
    The bug in FLINK-1453 would be more obvious with these changes were merged. 
That's another motivation for me to push this pull request forward ;)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to