[ 
https://issues.apache.org/jira/browse/FLINK-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293612#comment-14293612
 ] 

ASF GitHub Bot commented on FLINK-938:
--------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/248#discussion_r23611202
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -519,6 +519,12 @@ object JobManager {
               configuration.setString(ConfigConstants.FLINK_BASE_DIR_PATH_KEY, 
config.configDir + "/..")
             }
     
    +        if 
(GlobalConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +          null) == null) {
    +          
configuration.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +            InetAddress.getLocalHost.getHostName)
    +        }
    +
             val hostname = 
configuration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, null)
    --- End diff --
    
    Oh yes, you're right. Then it's perfectly fine.


> Change start-cluster.sh script so that users don't have to configure the 
> JobManager address
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-938
>                 URL: https://issues.apache.org/jira/browse/FLINK-938
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Mingliang Qi
>            Priority: Minor
>             Fix For: 0.9
>
>
> To improve the user experience, Flink should not require users to configure 
> the JobManager's address on a cluster.
> In combination with FLINK-934, this would allow running Flink with decent 
> performance on a cluster without setting a single configuration value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to