Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/339#issuecomment-71819301
With your latest changes Chesney, namely the incrementing/decrementing
logic, I think that it now makes sense again to increase the counters in the
createTmpFile method. Because otherwise the following could happen.
1. You create a new temp file but do not execute the copy process yet. The
respective counter is 1
2. You delete the same file and the delete process is immediately executed.
This would delete the file.
3. Now the copy process is started and has to transfer the file again even
though it was known at the time of deleting the file that it is still needed.
What do you think? Am I missing a point which prevents putting the
incrementing logic back into the createTmpFile method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
